Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade V8 to 9.2.230.10 #700

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Upgrade V8 to 9.2.230.10 #700

merged 6 commits into from
Jun 15, 2021

Conversation

ry
Copy link
Member

@ry ry commented Jun 10, 2021

We are floating a revert of v8/v8@7f9d7f0 because of the issue described
in #694.

We are floating a revert of v8/v8@7f9d7f0 because of the issue described
in #694.
@ry
Copy link
Member Author

ry commented Jun 10, 2021

Getting a segfault somewhere in snapshotting...

# cargo test  snap -- --nocapture
    Finished test [unoptimized + debuginfo] target(s) in 0.03s
     Running unittests (target/debug/deps/rusty_v8-68910e1788ac722b)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 11 filtered out; finished in 0.00s

     Running tests/slots.rs (target/debug/deps/slots-acc6ba8252a2fc15)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

     Running tests/test_api.rs (target/debug/deps/test_api-ed96c40d48b438fc)

running 4 tests
test create_params_snapshot_blob ... ok


#
# Fatal error in ../../../v8/src/heap/read-only-spaces.cc, line 69
# Check failed: read_only_blob_checksum_ == snapshot_checksum (<unprintable> vs. 2991053677).
#
#
#
#FailureMessage Object: 0x16d4c8c88
==== C stack trace ===============================

    0   test_api-ed96c40d48b438fc           0x0000000102e84bd4 v8::base::debug::StackTrace::StackTrace() + 24
    1   test_api-ed96c40d48b438fc           0x0000000102e8a328 v8::platform::(anonymous namespace)::PrintStackTrace() + 116
    2   test_api-ed96c40d48b438fc           0x0000000102e7b248 V8_Fatal(char const*, int, char const*, ...) + 268
    3   test_api-ed96c40d48b438fc           0x00000001032e927c v8::internal::ReadOnlyArtifacts::VerifyChecksum(v8::internal::SnapshotData*, bool) + 160
    4   test_api-ed96c40d48b438fc           0x00000001032e8334 v8::internal::ReadOnlyHeap::SetUp(v8::internal::Isolate*, v8::internal::SnapshotData*, bool) + 624
    5   test_api-ed96c40d48b438fc           0x000000010319bb98 v8::internal::Isolate::Init(v8::internal::SnapshotData*, v8::internal::SnapshotData*, bool) + 1076
    6   test_api-ed96c40d48b438fc           0x000000010319c8a0 v8::internal::Isolate::InitWithSnapshot(v8::internal::SnapshotData*, v8::internal::SnapshotData*, bool) + 60
    7   test_api-ed96c40d48b438fc           0x00000001038d7a98 v8::internal::Snapshot::Initialize(v8::internal::Isolate*) + 584
    8   test_api-ed96c40d48b438fc           0x0000000102f3fe8c v8::Isolate::Initialize(v8::Isolate*, v8::Isolate::CreateParams const&) + 452
    9   test_api-ed96c40d48b438fc           0x0000000102f4021c v8::Isolate::New(v8::Isolate::CreateParams const&) + 32
    10  test_api-ed96c40d48b438fc           0x0000000102e53210 v8__Isolate__New + 24
    11  test_api-ed96c40d48b438fc           0x0000000102e1f578 rusty_v8::isolate::Isolate::new::h1baa573a0844a5c7 + 136
    12  libsystem_pthread.dylib             0x000000018c3f9d3c thread_start + 8
error: test failed, to rerun pass '--test test_api'

Caused by:
  process didn't exit successfully: `/Users/ry/src/rusty_v8/target/debug/deps/test_api-ed96c40d48b438fc snap --nocapture` (signal: 5, SIGTRAP: trace/breakpoint trap)

@ry ry requested a review from piscisaureus June 15, 2021 12:25
@piscisaureus
Copy link
Member

Disabling shared readonly heap because of a faulty assert in debug mode: 😢

Upgrading at all: 🎉🎉🎉

@ry ry merged commit fe29835 into main Jun 15, 2021
@ry ry deleted the v8-9.2 branch June 15, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants