Improve auto lock and make it more customizable #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
force-pushed
the
improve-auto-lock
branch
from
f0e8566
to
6d89a8a
Compare
|
Rebased. |
michaelschattgen
requested changes
Aug 16, 2020
There was a problem hiding this comment.
Great work! This makes Aegis way more user friendly.
Minor issue here; is it possible to remove the switch in the preferences and add the selected options as subtitle of that preference? Just like how the theme, view mode and lanaguage preferences work. I don't think it's very intuitive the way it works now. I would never expect the switchpreference to trigger a dialog.
alexbakker
force-pushed
the
improve-auto-lock
branch
from
6d89a8a
to
3058196
Compare
|
You're right. I thought I was all clever doing that. Fixed. |
alexbakker
force-pushed
the
improve-auto-lock
branch
from
3058196
to
39e6cb8
Compare
This patch makes the auto lock option more customizable. Users can now choose a combination of the following: Locking Aegis when - The back button is pressed - The app is minimized - The device is locked <img src="https://alexbakker.me/u/rlj4y2u8pk.png" width="300">
alexbakker
force-pushed
the
improve-auto-lock
branch
from
39e6cb8
to
d875cb6
Compare
michaelschattgen
approved these changes
Aug 26, 2020
|
I really appreciate you working on this option set, and so soon after I made a feature request. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the auto lock option more customizable. Users can now choose a
combination of the following: Locking Aegis when
Close #541 and close #334.