Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let back button lock+close Aegis instead of returning to lock screen #541

Closed
mdmower opened this issue Jul 29, 2020 · 2 comments · Fixed by #564
Closed

Let back button lock+close Aegis instead of returning to lock screen #541

mdmower opened this issue Jul 29, 2020 · 2 comments · Fixed by #564
Assignees
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature
Milestone

Comments

@mdmower
Copy link

mdmower commented Jul 29, 2020

It would make a lot of sense if tapping "back" locked and closed Aegis instead of returning to the Aegis lock screen. How often do people think "I finished reading my TOTP code, now I would like to go back to the Aegis lock screen" compared to "I finished reading my TOTP code, now I'd like to securely exit Aegis"? In the (rarer) former case, reaching the lock screen is still possible by re-opening Aegis.

A couple of comments:

  • The "home" key performs as you'd expect, defocusing Aegis in a manner than does not require re-unlocking if Aegis regains focus. So, I don't think its behavior should be modified.
  • The closest issue I could find to this feature request is bug report Aegis doesn't close using the back button #182 (fixed in Add temporary backpress fix #192) which described an inability to close the app when at the lock screen. Sorry if this has already been requested and I didn't find the original issue.
@mdmower mdmower added the proposal A proposal for a new feature label Jul 29, 2020
@linsui
Copy link

linsui commented Jul 30, 2020

When I want to file a issue I find this. I hope that I can lock Aegis when I tap home. I hardly ever need to input another 2FA code after I input one.
The behavior of the back button is weird. I have to tap it three times to leave Aegis and lock it.

@alexbakker
Copy link
Member

Fair enough!

I hope that I can lock Aegis when I tap home. I hardly ever need to input another 2FA code after I input one.

See #334. We'll probably tackle both of these at the same time.

@alexbakker alexbakker added the proposal-accepted An accepted proposal for a new feature label Jul 30, 2020
@michaelschattgen michaelschattgen added this to the 1.4 milestone Aug 8, 2020
@alexbakker alexbakker self-assigned this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants