Adds checks for removal of ORFs during scoring. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OS X tests are timing out here: |
johnlees
approved these changes
Feb 22, 2024
Comment on lines
+405
to
+408
| if (centroid_entry == colour_ORF_vec_map[centroid_ID_pair.first].end()) | ||
| { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
It might be better to refactor this whole thing as an if/else rather than using continue (which can be a bit hard to follow). But doesn't matter too much – if that's difficult because it's a long or complex loop this is fine
There was a problem hiding this comment.
It's because the loop is parallelised, I'm not sure an if/else block would work with how openmp wants for loops to be structured.
I've worked out why this is happening - the OSX implementation doesn't work with the python shared memory objects being used. I'm planning to rewrite these sections fully in C++ to avoid this issue entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses out of range error, where occasionally multithreading will cause the same item to be remove from a map twice.