Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker #3

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Docker #3

merged 14 commits into from
Apr 3, 2024

Conversation

samhorsfield96
Copy link
Collaborator

Adds docker build

Comment on lines +58 to +60
```
docker pull samhorsfield96/celebrimbor:main
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to give one example command of how to use it as in e.g. the excellent ggcaller installation documentation:

cd test && docker run --rm -it -v $(pwd):/workdir samhorsfield96/ggcaller:latest ggcaller --refs pneumo_CL_group2.txt

Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good would just add an example command for the container

@samhorsfield96 samhorsfield96 merged commit 61849b5 into main Apr 3, 2024
2 checks passed
@samhorsfield96 samhorsfield96 deleted the docker branch April 3, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants