private/protocol/json/jsonutil: Fixes a bug that truncated millisecond precision time in API response to seconds #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
skotambkar
approved these changes
Aug 10, 2020
jasdel
approved these changes
Aug 10, 2020
jasdel
reviewed
Aug 11, 2020
skmcgrail
changed the title
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Aug 12, 2020
=== ### Service Client Updates * `service/cloud9`: Updates service API and documentation * Add ConnectionType input parameter to CreateEnvironmentEC2 endpoint. New parameter enables creation of environments with SSM connection. * `service/comprehend`: Updates service documentation * `service/ec2`: Updates service API and documentation * Introduces support for IPv6-in-IPv4 IPsec tunnels. A user can now send traffic from their on-premise IPv6 network to AWS VPCs that have IPv6 support enabled. * `service/fsx`: Updates service API and documentation * `service/iot`: Updates service API, documentation, and paginators * Audit finding suppressions: Device Defender enables customers to turn off non-compliant findings for specific resources on a per check basis. * `service/lambda`: Updates service API and examples * Support for creating Lambda Functions using 'java8.al2' and 'provided.al2' * `service/transfer`: Updates service API, documentation, and paginators * Adds security policies to control cryptographic algorithms advertised by your server, additional characters in usernames and length increase, and FIPS compliant endpoints in the US and Canada regions. * `service/workspaces`: Updates service API and documentation * Adds optional EnableWorkDocs property to WorkspaceCreationProperties in the ModifyWorkspaceCreationProperties API ### SDK Enhancements * `codegen`: Add XXX_Values functions for getting slice of API enums by type. * Fixes [#3441](#3441) by adding a new XXX_Values function for each API enum type that returns a slice of enum values, e.g `DomainStatus_Values`. * `aws/request`: Update default retry to retry "use of closed network connection" errors ([#3476](#3476)) * Fixes [#3406](#3406) ### SDK Bugs * `private/protocol/json/jsonutil`: Fixes a bug that truncated millisecond precision time in API response to seconds. ([#3474](#3474)) * Fixes [#3464](#3464) * Fixes [#3410](#3410) * `codegen`: Export event stream constructor for easier mocking ([#3473](#3473)) * Fixes [#3412](#3412) by exporting the operation's EventStream type's constructor function so it can be used to fully initialize fully when mocking out behavior for API operations with event streams. * `service/ec2`: Fix max retries with client customizations ([#3465](#3465)) * Fixes [#3374](#3374) by correcting the EC2 API client's customization for ModifyNetworkInterfaceAttribute and AssignPrivateIpAddresses operations to use the aws.Config.MaxRetries value if set. Previously the API client's customizations would ignore MaxRetries specified in the SDK's aws.Config.MaxRetries field.
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Aug 12, 2020
Release v1.34.3 (2020-08-12) === ### Service Client Updates * `service/cloud9`: Updates service API and documentation * Add ConnectionType input parameter to CreateEnvironmentEC2 endpoint. New parameter enables creation of environments with SSM connection. * `service/comprehend`: Updates service documentation * `service/ec2`: Updates service API and documentation * Introduces support for IPv6-in-IPv4 IPsec tunnels. A user can now send traffic from their on-premise IPv6 network to AWS VPCs that have IPv6 support enabled. * `service/fsx`: Updates service API and documentation * `service/iot`: Updates service API, documentation, and paginators * Audit finding suppressions: Device Defender enables customers to turn off non-compliant findings for specific resources on a per check basis. * `service/lambda`: Updates service API and examples * Support for creating Lambda Functions using 'java8.al2' and 'provided.al2' * `service/transfer`: Updates service API, documentation, and paginators * Adds security policies to control cryptographic algorithms advertised by your server, additional characters in usernames and length increase, and FIPS compliant endpoints in the US and Canada regions. * `service/workspaces`: Updates service API and documentation * Adds optional EnableWorkDocs property to WorkspaceCreationProperties in the ModifyWorkspaceCreationProperties API ### SDK Enhancements * `codegen`: Add XXX_Values functions for getting slice of API enums by type. * Fixes [#3441](#3441) by adding a new XXX_Values function for each API enum type that returns a slice of enum values, e.g `DomainStatus_Values`. * `aws/request`: Update default retry to retry "use of closed network connection" errors ([#3476](#3476)) * Fixes [#3406](#3406) ### SDK Bugs * `private/protocol/json/jsonutil`: Fixes a bug that truncated millisecond precision time in API response to seconds. ([#3474](#3474)) * Fixes [#3464](#3464) * Fixes [#3410](#3410) * `codegen`: Export event stream constructor for easier mocking ([#3473](#3473)) * Fixes [#3412](#3412) by exporting the operation's EventStream type's constructor function so it can be used to fully initialize fully when mocking out behavior for API operations with event streams. * `service/ec2`: Fix max retries with client customizations ([#3465](#3465)) * Fixes [#3374](#3374) by correcting the EC2 API client's customization for ModifyNetworkInterfaceAttribute and AssignPrivateIpAddresses operations to use the aws.Config.MaxRetries value if set. Previously the API client's customizations would ignore MaxRetries specified in the SDK's aws.Config.MaxRetries field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a timestamp truncation issue for JSON protocols. On serialization we support sending millisecond precision UNIX timestamps to services, but on deserialization of service responses the millisecond precision timestamps were truncated when passed to
time.Unix.Fixes #3464
Fixes #3410