Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step Functions GetExecutionHistory timestamps lose precision #3464

Closed
3 tasks done
aidansteele opened this issue Aug 7, 2020 · 1 comment · Fixed by #3474 or #3479
Closed
3 tasks done

Step Functions GetExecutionHistory timestamps lose precision #3464

aidansteele opened this issue Aug 7, 2020 · 1 comment · Fixed by #3474 or #3479
Labels
bug This issue is a bug.

Comments

@aidansteele
Copy link

Describe the bug

aws-sdk-go/service/sfn/api.go

Line 4449 in b811ea8

Timestamp *time.Time `locationName:"timestamp" type:"timestamp" required:"true"`

The timestamp of a Step Function execution history event is truncated to second granularity. Stepping through the debugger shows that it gets parsed into a *time.Time here, which documents the behaviour:

aws-sdk-go/private/protocol/json/jsonutil/unmarshal.go

Lines 264 to 266 in b811ea8

case *time.Time:
// Time unmarshaled from a float64 can only be epoch seconds
t := time.Unix(int64(d), 0).UTC()

The underlying JSON on the wire looks like "timestamp": 1596731423.048. Unfortunately I am not familiar enough with the tags/struct metadata required to submit a PR to fix this.

Version of AWS SDK for Go?
v1.33.21

Version of Go (go version)?
go version go1.14.5 darwin/amd64
@aidansteele aidansteele added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2020
@diehlaws diehlaws self-assigned this Aug 7, 2020
@diehlaws diehlaws removed the needs-triage This issue or PR still needs to be triaged. label Aug 7, 2020
@diehlaws
Copy link
Contributor

diehlaws commented Aug 7, 2020

Hi @aidansteele, thanks for bringing this to our attention. This behavior sounds similar to what's described in #3410. I'll bring this up with the rest of the team for further investigation during our next sprint. In the meantime, can you provide debug output including the HTTP response body for a call that exhibits this behavior, along with the GetExecutionHistoryOutput returned by the SDK for this call?

@diehlaws diehlaws added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 7, 2020
@skmcgrail skmcgrail mentioned this issue Aug 10, 2020
Merged
@skmcgrail skmcgrail removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 10, 2020
aws-sdk-go-automation pushed a commit that referenced this issue Aug 12, 2020
Release v1.34.3 (2020-08-12)
3386d60 
===

### Service Client Updates
* `service/cloud9`: Updates service API and documentation
  * Add ConnectionType input parameter to CreateEnvironmentEC2 endpoint. New parameter enables creation of environments with SSM connection.
* `service/comprehend`: Updates service documentation
* `service/ec2`: Updates service API and documentation
  * Introduces support for IPv6-in-IPv4 IPsec tunnels. A user can now send traffic from their on-premise IPv6 network to AWS VPCs that have IPv6 support enabled.
* `service/fsx`: Updates service API and documentation
* `service/iot`: Updates service API, documentation, and paginators
  * Audit finding suppressions: Device Defender enables customers to turn off non-compliant findings for specific resources on a per check basis.
* `service/lambda`: Updates service API and examples
  * Support for creating Lambda Functions using 'java8.al2' and 'provided.al2'
* `service/transfer`: Updates service API, documentation, and paginators
  * Adds security policies to control cryptographic algorithms advertised by your server, additional characters in usernames and length increase, and FIPS compliant endpoints in the US and Canada regions.
* `service/workspaces`: Updates service API and documentation
  * Adds optional EnableWorkDocs property to WorkspaceCreationProperties in the ModifyWorkspaceCreationProperties API

### SDK Enhancements
* `codegen`: Add XXX_Values functions for getting slice of API enums by type.
  * Fixes [#3441](#3441) by adding a new XXX_Values function for each API enum type that returns a slice of enum values, e.g `DomainStatus_Values`.
* `aws/request`: Update default retry to retry "use of closed network connection" errors ([#3476](#3476))
  * Fixes [#3406](#3406)

### SDK Bugs
* `private/protocol/json/jsonutil`: Fixes a bug that truncated millisecond precision time in API response to seconds. ([#3474](#3474))
  * Fixes [#3464](#3464)
  * Fixes [#3410](#3410)
* `codegen`: Export event stream constructor for easier mocking ([#3473](#3473))
  * Fixes [#3412](#3412) by exporting the operation's EventStream type's constructor function so it can be used to fully initialize fully when mocking out behavior for API operations with event streams.
* `service/ec2`: Fix max retries with client customizations ([#3465](#3465))
  * Fixes [#3374](#3374) by correcting the EC2 API client's customization for ModifyNetworkInterfaceAttribute and AssignPrivateIpAddresses operations to use the aws.Config.MaxRetries value if set. Previously the API client's customizations would ignore MaxRetries specified in the SDK's aws.Config.MaxRetries field.
Merged
aws-sdk-go-automation added a commit that referenced this issue Aug 12, 2020
@aws-sdk-go-automation
Release v1.34.3 (2020-08-12) (#3479)
20cd465 
Release v1.34.3 (2020-08-12)
===

### Service Client Updates
* `service/cloud9`: Updates service API and documentation
  * Add ConnectionType input parameter to CreateEnvironmentEC2 endpoint. New parameter enables creation of environments with SSM connection.
* `service/comprehend`: Updates service documentation
* `service/ec2`: Updates service API and documentation
  * Introduces support for IPv6-in-IPv4 IPsec tunnels. A user can now send traffic from their on-premise IPv6 network to AWS VPCs that have IPv6 support enabled.
* `service/fsx`: Updates service API and documentation
* `service/iot`: Updates service API, documentation, and paginators
  * Audit finding suppressions: Device Defender enables customers to turn off non-compliant findings for specific resources on a per check basis.
* `service/lambda`: Updates service API and examples
  * Support for creating Lambda Functions using 'java8.al2' and 'provided.al2'
* `service/transfer`: Updates service API, documentation, and paginators
  * Adds security policies to control cryptographic algorithms advertised by your server, additional characters in usernames and length increase, and FIPS compliant endpoints in the US and Canada regions.
* `service/workspaces`: Updates service API and documentation
  * Adds optional EnableWorkDocs property to WorkspaceCreationProperties in the ModifyWorkspaceCreationProperties API

### SDK Enhancements
* `codegen`: Add XXX_Values functions for getting slice of API enums by type.
  * Fixes [#3441](#3441) by adding a new XXX_Values function for each API enum type that returns a slice of enum values, e.g `DomainStatus_Values`.
* `aws/request`: Update default retry to retry "use of closed network connection" errors ([#3476](#3476))
  * Fixes [#3406](#3406)

### SDK Bugs
* `private/protocol/json/jsonutil`: Fixes a bug that truncated millisecond precision time in API response to seconds. ([#3474](#3474))
  * Fixes [#3464](#3464)
  * Fixes [#3410](#3410)
* `codegen`: Export event stream constructor for easier mocking ([#3473](#3473))
  * Fixes [#3412](#3412) by exporting the operation's EventStream type's constructor function so it can be used to fully initialize fully when mocking out behavior for API operations with event streams.
* `service/ec2`: Fix max retries with client customizations ([#3465](#3465))
  * Fixes [#3374](#3374) by correcting the EC2 API client's customization for ModifyNetworkInterfaceAttribute and AssignPrivateIpAddresses operations to use the aws.Config.MaxRetries value if set. Previously the API client's customizations would ignore MaxRetries specified in the SDK's aws.Config.MaxRetries field.
@diehlaws diehlaws removed their assignment Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
3 participants
@aidansteele @skmcgrail @diehlaws