[Develop] Fix test_proxy integ test #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehe7318
added
skip-changelog-update
| @@ -74,7 +74,7 @@ def get_instance_public_ip(instance_id, region): | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures("region", "os", "instance", "scheduler") | |||
| def test_proxy(pcluster_config_reader, clusters_factory, proxy_stack_factory, scheduler_commands_factory): | |||
There was a problem hiding this comment.
Even better, clusters_factory could be between proxy_stack_factory and proxy_stack_factory
There was a problem hiding this comment.
You mean proxy_stack_factory and scheduler_commands_factory, right?
Done!
hanwen-pcluste
previously approved these changes
Jun 20, 2024
hanwen-pcluste
approved these changes
Jun 20, 2024
gmarciani
reviewed
Jun 24, 2024
| @@ -4,6 +4,7 @@ HeadNode: | |||
| InstanceType: {{ instance }} | |||
| Ssh: | |||
| KeyName: {{ key_name }} | |||
| AllowedIps: 0.0.0.0/0 | |||
There was a problem hiding this comment.
This is too permissive. Can we restrict it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
paramiko.ssh_exception.SSHException: No existing sessionandparamiko.ssh_exception.SSHException: Error reading SSH protocol bannerissues.AllowedIps: 0.0.0.0/0in cluster config to fix itTests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.