Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Add an end2end test to validate the proxy use case #6268

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jun 5, 2024

Description of changes

  • Added a new integration test to validate the proxy use case.
  • Use cloudformation/proxy/proxy.yaml to deploy the proxy environment.
    • The proxy environment includes necessary networking, instances, and security groups.
  • The test performs the following steps:
    1. Deploy the proxy environment using the CloudFormation stack.
    2. Create a ParallelCluster using the proxy environment.
    3. Connect to HeadNode through bastion.
    4. Check internet access by trying to access google.com
    5. Submit a sleep job to the cluster and verify its successful completion.

Tests

  • Locally test can pass successfully now.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jun 5, 2024
@hehe7318 hehe7318 requested review from a team as code owners June 5, 2024 03:15
@hehe7318 hehe7318 changed the title [Develop][Draft] Add an end2end test to validate the proxy use case [Develop] Add an end2end test to validate the proxy use case Jun 10, 2024
- Added a new integration test to validate the proxy use case.
- Created a CloudFormation stack (proxy_stack) to deploy the proxy environment.
  - The proxy environment includes necessary networking, instances, and security groups.
- The test performs the following steps:
  1. Deploy the proxy environment using the CloudFormation stack.
  2. Create a ParallelCluster using the proxy environment.
  3. Submit a sleep job to the cluster and verify its successful completion.
…template to add an optional parameter for the CIDR to allow SSH traffic from. 3. Add the policy AmazonSSMManagedInstanceCore to both the head node and compute node. 4. Minor changes
@hehe7318 hehe7318 merged commit 5c54348 into aws:develop Jun 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants