Unpin kernel update in rhel platform family #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are pinning to specific kernel version in nvidia_install recepie, but centos6 ami we have is very old and the specific version of kernel is not available in repository during downgrade. Hence removing specific kernel version install for rhel platform family Signed-off-by: Mohan Gandhi <[email protected]>
bwbarrett
reviewed
Nov 7, 2017
| @@ -18,10 +18,7 @@ | |||
|
|
|||
| case node['platform_family'] | |||
| when 'rhel' | |||
| yum_package node['cfncluster']['kernel_devel_pkg']['name'] do | |||
| version node['cfncluster']['kernel_devel_pkg']['version'] | |||
There was a problem hiding this comment.
is there a 'version' set somewhere that we should remove to not confuse ourselves later?
There was a problem hiding this comment.
https://github.com/awslabs/cfncluster-cookbook/search?utf8=%E2%9C%93&q=%22yum_package%22&type=
https://github.com/awslabs/cfncluster-cookbook/search?utf8=%E2%9C%93&q=kernel_devel_pkg&type=
I don't see any other place where version is pin'ed with yum install.
There was a problem hiding this comment.
Added an Issue to cleanup aws/aws-parallelcluster#253 . Currently we still depend on version in apt install. Once we remove that i am happy to clean all setter.
rajachan
approved these changes
Nov 7, 2017
mohanasudhan
added a commit
that referenced
this pull request
Dec 1, 2017
We are pinning to specific kernel version in nvidia_install recepie, but centos6 ami we have is very old and the specific version of kernel is not available in repository during downgrade. Hence removing specific kernel version install for rhel platform family Signed-off-by: Mohan Gandhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are pinning to specific kernel version in nvidia_install
recepie, but centos6 ami we have is very old and the specific
version of kernel is not available in repository during
downgrade. Hence removing specific kernel version install for rhel
platform family
Signed-off-by: Mohan Gandhi [email protected]