Fix typescript declarations for v2 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callback is supported on getSigningKey
davidpatrick
changed the title
davidpatrick
approved these changes
Mar 12, 2021
|
Thanks @baywet for the quick catch here |
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 removed the callback based methods from the client and removed the Async suffix from the promise based methods.
The typescript prototype was not aligned with this change though, which makes it hard for typescript developers to "catch" such change by upgrading the package.
It also makes it hard for first time users of this package to discover the methods and what's available.
This PR fixes the misalignment created by the changes in v2
Closes #228 and #230