Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typescript types #230

Closed
wants to merge 1 commit into from
Closed

fix typescript types #230

wants to merge 1 commit into from

Conversation

itajaja
Copy link
Contributor

@itajaja itajaja commented Mar 12, 2021

fixes #228

two fixes:

  • drop old async signature for the new ones
  • fetcher shouldn't really return a SigningKey, becuase that's a complex instance with methods. there might be a better signature than any but I think this is good enough considering the scope of this (ie we don't want to define all possible fields of a jwk)

@itajaja itajaja requested a review from a team as a code owner March 12, 2021 16:06
@itajaja itajaja mentioned this pull request Mar 12, 2021
Closed
@davidpatrick davidpatrick mentioned this pull request Mar 12, 2021
Merged
@itajaja
Copy link
Contributor Author

itajaja commented Mar 12, 2021

@davidpatrick there was still the fix for fetcher here. do you want me to do it in a separate PR?

@itajaja itajaja mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update typescript definition for 2.0.0 release
2 participants
@itajaja @davidpatrick