Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full JWK/JWS support #205

Merged
merged 6 commits into from
Jan 7, 2021
Merged

full JWK/JWS support #205

merged 6 commits into from
Jan 7, 2021

Conversation

panva
Copy link
Contributor

@panva panva commented Dec 9, 2020 •
edited
Loading

Description

This PR contains support for all currently registered JWK types and JWS Algorithms.

References

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Closes #170
Closes #40
Closes #50
Closes #11

Credit goes to @ivn-cote for his work on #170. Note that, just like #170 this warrants a new major release due to dependency's node runtime requirements, the removal of nbf passthrough (nbf on a JWK isn't standardized) as well as proper JWK parsing rules put forth by the inclusion of jose.

@panva panva requested a review from a team as a code owner December 9, 2020 12:40
@panva panva changed the title start full JWK/JWS support Dec 9, 2020
@panva panva marked this pull request as draft December 9, 2020 12:54
@panva panva marked this pull request as ready for review December 9, 2020 13:29
@davidpatrick davidpatrick added this to the v2-Next milestone Dec 10, 2020
@ivn-cote
Copy link
Contributor

Thank you for pushing the change!

davidpatrick
davidpatrick previously approved these changes Jan 4, 2021
View reviewed changes
adamjmcgrath
adamjmcgrath previously approved these changes Jan 5, 2021
View reviewed changes
@davidpatrick davidpatrick dismissed stale reviews from adamjmcgrath and themself via 7d6d795 January 7, 2021 00:21
davidpatrick
davidpatrick previously approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@davidpatrick davidpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased with master, resolved conflicts on the package lock

@davidpatrick davidpatrick merged commit 61d4343 into auth0:master Jan 7, 2021
@ivn-cote
Copy link
Contributor

@davidpatrick thanks for the pushing the project forward! I see there is a next milestone https://github.com/auth0/node-jwks-rsa/milestone/7?closed=1
Can you maybe push beta version of the package to NPM please?

@davidpatrick
Copy link
Contributor

@ivn-cote sorry for the delay on this, we are moving forward with this release this week

@panva panva deleted the EC-support branch February 5, 2021 09:27
This was referenced Feb 23, 2021
Closed
Merged
This was referenced Mar 12, 2021
Closed
Closed
Merged
This was referenced Mar 12, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
@toomuchdesign toomuchdesign mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

@adamjmcgrath adamjmcgrath adamjmcgrath left review comments

Assignees
No one assigned
Labels
CH: Added CH: Breaking Change
Projects
None yet
Milestone
2.0.0
4 participants
@panva @ivn-cote @davidpatrick @adamjmcgrath