Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other algorithms? #40

Closed
thomaux opened this issue Apr 9, 2018 · 6 comments · Fixed by #205
Closed

Support for other algorithms? #40

thomaux opened this issue Apr 9, 2018 · 6 comments · Fixed by #205
Labels
closed:stale Issue or PR has not seen activity recently

Comments

@thomaux
Copy link

thomaux commented Apr 9, 2018

I'm currently looking for a library facilitating getting the keys from a JWKS endpoint. However, in our application we're using the ES256 algorithm for signing. I'm thus a little bit bummed to notice this library, which would seem to be a perfect fit for the problem I'm trying to solve, has a hard coded check on the key type.

I'm wondering:

  • as to why there's only support for the RSA algorithm
  • if there are plans to support other algorithms in the future
  • if you know any alternatives (after some extensive Googling, I have found none)
  • whether you would be open to a PR supporting other algorithms

Many thanks,
Thomas

@whatupdave
Copy link

Or at least throw an error maybe? Took a while to figure this out.

@faizalMo
Copy link

I have an application that is using ES256 as well and the lack of support for that is hurting, did you find any solution @thomaux

@thomaux
Copy link
Author

thomaux commented Aug 16, 2018

@ShahOfMEC We have a custom implementation, but I'd rather replace that with a tried and tested one.

@wyattjoh
Copy link

Also very interested if anyone has an alternative library that we can use with https://github.com/coralproject/talk!

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Oct 26, 2019
@stale stale bot closed this as completed Nov 2, 2019
@danielcherubini
Copy link

@wyattjoh I built a EC library that's a fork of this one

https://gitlab.com/danielcherubini/node-jwks-ec

@panva panva mentioned this issue Dec 9, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:stale Issue or PR has not seen activity recently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants