Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript definition for 2.0.0 release #228

Closed
mlegenhausen opened this issue Mar 12, 2021 · 1 comment · Fixed by #229
Closed

Update typescript definition for 2.0.0 release #228

mlegenhausen opened this issue Mar 12, 2021 · 1 comment · Fixed by #229

Comments

@mlegenhausen
Copy link

mlegenhausen commented Mar 12, 2021 •
edited
Loading

Describe the problem

The typescript definition are not aligned with the new callback free implementation in release 2.0.0

What was the expected behavior?

Working typescript definitions.

Reproduction

Environment

  • Version of this library used: 2.0.0
  • Which framework are you using, if applicable: [email protected]
  • Other modules/plugins/libraries that might be involved:
  • Any other relevant information you think would be useful:
itajaja added a commit to itajaja/node-jwks-rsa that referenced this issue Mar 12, 2021
@itajaja
fix typescript types
7b296d5 
fixes auth0#228
@itajaja itajaja mentioned this issue Mar 12, 2021
Closed
@itajaja
Copy link
Contributor

itajaja commented Mar 12, 2021

took a stab here #230

@davidpatrick davidpatrick mentioned this issue Mar 12, 2021
Merged
davidpatrick pushed a commit that referenced this issue Mar 12, 2021
@itajaja
Fix typescript types for fetcher (#231)
38e84e0 
* fix typescript types

fixes #228

* Update index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typescript declarations for v2
fix typescript types itajaja/node-jwks-rsa
2 participants
@mlegenhausen @itajaja