Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to panic='abort' for safety across FFI boundaries #184

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Switch to panic='abort' for safety across FFI boundaries #184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8da8b6
Switch to panic='abort' for safety across FFI boundaries
ValarDragon Jan 21, 2021
56efaa4
Apply changelog update
ValarDragon Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Switch to panic='abort' for safety across FFI boundaries 
Thanks to @daira for pointing out the security impact, and
@jon-chuang for raising the issue / pointing out perf improvements.

This still needs to be done in downstream repositories, as this
change only applies to the top level crate.
  • Loading branch information
@ValarDragon
ValarDragon committed Jan 21, 2021
commit b8da8b6ea2defe1bbd6147d5080cce8785716f9d
2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ members = [
opt-level = 3
lto = "thin"
incremental = true
panic = 'abort'

[profile.bench]
opt-level = 3
Expand All @@ -30,6 +31,7 @@ debug-assertions = false

[profile.dev]
opt-level = 0
panic = 'abort'
Pratyush marked this conversation as resolved.
Show resolved Hide resolved

[profile.test]
opt-level = 3
Expand Down