Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to panic='abort' for safety across FFI boundaries #184

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jan 21, 2021

Thanks to @daira for pointing out the security impact, and @jon-chuang for raising the issue / pointing out perf improvements.

This still needs to be done in downstream repositories, as this change only applies to the top level crate.

closes: #183

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests - n/a?
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Thanks to @daira for pointing out the security impact, and
@jon-chuang for raising the issue / pointing out perf improvements.

This still needs to be done in downstream repositories, as this
change only applies to the top level crate.
@Pratyush
Copy link
Member

Doesn’t this only affect our libraries, and not any downstream binaries?

@ValarDragon
Copy link
Member Author

Yes. my understanding of the profile docs is that this will only take precedence for FFI that is obtained from compiling algebra directly. (E.g. golang code using FFI for this curve arithmetic, and implementing BLS with it)

I don't think this is a big concern for algebra, but is much more likely to be one for groth16, and it doesn't really hurt to do it in all libraries.

Cargo.toml Show resolved Hide resolved
@Pratyush Pratyush merged commit 1ebaf95 into master Jan 21, 2021
@Pratyush Pratyush deleted the panic_abort branch January 21, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic = "abort" on release
2 participants