Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: P/R/C reporting in argo list -o wide. Fixes #9281 #9874

Merged
merged 3 commits into from
Oct 21, 2022
Merged

fix: P/R/C reporting in argo list -o wide. Fixes #9281 #9874

merged 3 commits into from
Oct 21, 2022

Conversation

aditya-shrivastava
Copy link
Contributor

@aditya-shrivastava aditya-shrivastava commented Oct 21, 2022 •
edited
Loading

Signed-off-by: aditya-shrivastava [email protected]

Fixes #9281

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

E2E tests already present in https://github.com/argoproj/argo-workflows/blob/master/test/e2e/cli_test.go

@aditya-shrivastava aditya-shrivastava changed the title fix P/R/C reporting in argo list wide. Fixes #9281 fix P/R/C reporting in argo list -o wide. Fixes #9281 Oct 21, 2022
@aditya-shrivastava aditya-shrivastava marked this pull request as ready for review October 21, 2022 08:11
@aditya-shrivastava aditya-shrivastava mentioned this pull request Oct 21, 2022
Closed
@terrytangyuan terrytangyuan changed the title fix P/R/C reporting in argo list -o wide. Fixes #9281 fix: P/R/C reporting in argo list -o wide. Fixes #9281 Oct 21, 2022
@terrytangyuan terrytangyuan merged commit ec51629 into argoproj:master Oct 21, 2022
@aditya-shrivastava aditya-shrivastava deleted the fix-prc-reporting-list-wide branch October 21, 2022 19:50
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
@aditya-shrivastava @juchaosong
fix: P/R/C reporting in argo list -o wide. Fixes argoproj#9281 (argop…
b1c2b0b 
…roj#9874)

Signed-off-by: aditya-shrivastava <[email protected]>
Signed-off-by: juchao <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does P/R/C reporting on argo list -o wide still work?
2 participants
@aditya-shrivastava @terrytangyuan