I would like a mentor

[aditya-shrivastava]

Question: Have you read the mentoring guide? Please only submit this request for general mentoring (not GSoC).

Answer: Yes I have read the mentoring guide.

What is your background? Any experience with Go, Kubernetes, React, Typescript, etc.?

Answer: I have previous experience in React.

Is there any particular issue you'd like to work on? You may want to check out the list of good first issues.

Answer: I would like to work with issue #9281

Do you want to work with your mentor async (i.e. by Slack messaging or issue comments), or sync (e.g. using Zoom video)? Please include your time-zone if you want to work sync.

Answer: (async)

[terrytangyuan]

Feel free to start working on that issue and let us know if you have any questions.

[aditya-shrivastava]

Hi @terrytangyuan, I have made some changes and the bug seems to be fixed. I have added a comment in the issue #9281 with snapshots of the same. Can I get some feedback on it? 😄

[terrytangyuan]

Could you send a PR, and the team will review it?

[aditya-shrivastava]

Sure, I will do that.
Can you tell me what unit tests I should be adding before sending a PR? I don't have much experience with TDD so I am learning how to write tests.

[terrytangyuan]

It should be part of this test suite: https://github.com/argoproj/argo-workflows/blob/master/test/e2e/cli_test.go

[aditya-shrivastava]

Thanks for the help. I was able to make a PR #9874 but one of the checks seems to have timed out and got cancelled. How can I re-run the checks?

[terrytangyuan]

You can trigger the CI by pushing new commits.

[aditya-shrivastava]

Thanks all the checks have passed now. I have marked the PR as "Ready for review".

[terrytangyuan]

Merged. Congrats on your first contribution!

[aditya-shrivastava]

Thanks. I would definitely try and contribute more. 😃