Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade to Golang 1.18 #8371

Merged
merged 4 commits into from
Apr 12, 2022
Merged

chore: Upgrade to Golang 1.18 #8371

merged 4 commits into from
Apr 12, 2022

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Apr 11, 2022 •
edited
Loading

Many other projects started using 1.18 and the Go workspace to work with multi-projects is especially useful.

Signed-off-by: Yuan Tang [email protected]

alexec
alexec reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see several other places that need updating, including Dockerfile.windows and gh-pages.yaml, go.mod, running-locally.md

@terrytangyuan terrytangyuan enabled auto-merge (squash) April 11, 2022 23:22
alexec
alexec requested changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build broken

@terrytangyuan
fix: conflict
c141e6f 
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan terrytangyuan merged commit f39d142 into argoproj:master Apr 12, 2022
@terrytangyuan terrytangyuan deleted the chore-go branch April 12, 2022 21:47
brianloss pushed a commit to brianloss/argo-workflows that referenced this pull request Jun 28, 2022
@terrytangyuan @brianloss
chore: Upgrade to Golang 1.18 (argoproj#8371)
82fedac 
Signed-off-by: Brian Loss <[email protected]>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @alexec @agilgur5