Skip to content

Commit

Permalink
chore: Upgrade to Golang 1.18 (#8371)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrytangyuan committed Apr 12, 2022
1 parent 95323f8 commit f39d142
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 723 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: "1.17"
go-version: "1.18"
# https://github.com/actions/cache/blob/main/examples.md#go---modules
- uses: actions/cache@v3
with:
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: "1.17"
go-version: "1.18"
- uses: actions/setup-java@v3
with:
java-version: '8'
Expand Down Expand Up @@ -168,7 +168,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: "1.17"
go-version: "1.18"
- uses: actions/cache@v3
with:
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
python-version: 3.9
- uses: actions/setup-go@v3
with:
go-version: '1.17'
go-version: '1.18'
- run: pip install mkdocs==1.2.4 mkdocs_material==8.1.9
- run: mkdocs build
- run: make parse-examples
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ jobs:
node-version: "16"
- uses: actions/setup-go@v3
with:
go-version: "1.17"
go-version: "1.18"
- uses: actions/cache@v3
with:
path: ui/node_modules
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#syntax=docker/dockerfile:1.2

FROM golang:1.17 as builder
FROM golang:1.18 as builder

RUN apt-get update && apt-get --no-install-recommends install -y \
git \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.windows
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ARG IMAGE_OS_VERSION=1809

# had issues with official golange image for windows so I'm using plain servercore
FROM mcr.microsoft.com/windows/servercore:${IMAGE_OS_VERSION} as builder
ENV GOLANG_VERSION=1.17
ENV GOLANG_VERSION=1.18
SHELL ["powershell", "-Command"]

# install chocolatey package manager
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ dist/argosay:

.PHONY: pull-images
pull-images:
docker pull golang:1.17
docker pull golang:1.18
docker pull debian:10.7-slim
docker pull mysql:8
docker pull argoproj/argosay:v1
Expand Down
2 changes: 1 addition & 1 deletion docs/running-locally.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Requirements

* [Go 1.17](https://golang.org/dl/)
* [Go 1.18](https://golang.org/dl/)
* [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
* [Docker](https://docs.docker.com/get-docker/)
* [protoc](http:https://google.github.io/proto-lens/installing-protoc.html)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/argoproj/argo-workflows/v3

go 1.17
go 1.18

require (
cloud.google.com/go/storage v1.22.0
Expand Down
713 changes: 0 additions & 713 deletions go.sum

Large diffs are not rendered by default.

0 comments on commit f39d142

Please sign in to comment.