Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default value is ignored when loading params from configmap. Fixes #8262 #8271

Merged
merged 7 commits into from
Apr 2, 2022

Conversation

terrytangyuan
Copy link
Member

Fixes #8262.

Signed-off-by: Yuan Tang [email protected]

workflow/common/util.go Outdated Show resolved Hide resolved
@terrytangyuan terrytangyuan marked this pull request as draft March 28, 2022 17:16
@terrytangyuan terrytangyuan marked this pull request as ready for review March 31, 2022 18:20
@alexec alexec enabled auto-merge (squash) March 31, 2022 18:31
@alexec alexec merged commit 9c90145 into argoproj:master Apr 2, 2022
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
@alexec alexec mentioned this pull request May 3, 2022
alexec pushed a commit that referenced this pull request May 3, 2022
@terrytangyuan terrytangyuan deleted the fix-cm-default-param branch May 13, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigmapRef does not respect optional and default keyword
2 participants