-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default not respected in configMapKeyRef
when used to set global parameters
#9745
Closed
2 of 3 tasks
Labels
Comments
phlax
changed the title
default not respected in
default not respected in Oct 4, 2022
ConfigKeyMapRef
when used to set global parametersConfigMapKeyRef
when used to set global parameters
phlax
changed the title
default not respected in
default not respected in Oct 4, 2022
ConfigMapKeyRef
when used to set global parametersconfigMapKeyRef
when used to set global parameters
@phlax Do you like to fix this issue? |
i would like to but my go-fu is weak so probably im not best placed to |
alexec
pushed a commit
that referenced
this issue
Oct 10, 2022
…9745 (#9758) Signed-off-by: Rohan Kumar <[email protected]>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this issue
Nov 3, 2022
…rgoproj#9745 (argoproj#9758) Signed-off-by: Rohan Kumar <[email protected]> Signed-off-by: juchao <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pre-requisites
:latest
What happened/what you expected to happen?
Allowing a default value for a
ConfigMapKeyRef
was added in #8271 (ref #8262)It does not appear that this works for global workflow parameters
argo-workflows/workflow/controller/operator.go
Lines 578 to 584 in 2f5e753
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}
N/A
Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
N/A
The text was updated successfully, but these errors were encountered: