Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Only hydrate nodes if they are needed. Fixes #6000 #6004

Merged
merged 11 commits into from
May 27, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 25, 2021

No description provided.

@alexec alexec linked an issue May 25, 2021 that may be closed by this pull request
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title ci: only run changelog job on tag feat(server): Enable pprof. Relates to #6000 May 25, 2021
Signed-off-by: Alex Collins <[email protected]>
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6004 (970f272) into master (bad6155) will increase coverage by 0.03%.
The diff coverage is 49.31%.

❗ Current head 970f272 differs from pull request most recent head 5ee5103. Consider uploading reports for the commit 5ee5103 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6004      +/-   ##
==========================================
+ Coverage   47.33%   47.36%   +0.03%     
==========================================
  Files         248      248              
  Lines       15663    15688      +25     
==========================================
+ Hits         7414     7431      +17     
- Misses       7316     7321       +5     
- Partials      933      936       +3     
Impacted Files Coverage Δ
cmd/argo/commands/server.go 31.70% <0.00%> (-2.21%) ⬇️
server/workflow/workflow_server.go 44.28% <24.13%> (+1.55%) ⬆️
util/fields/fields.go 79.59% <80.55%> (-7.51%) ⬇️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.45% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 70.60% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad6155...5ee5103. Read the comment docs.

@alexec alexec marked this pull request as ready for review May 25, 2021 17:13
@alexec alexec added this to the v3.0 milestone May 25, 2021
@alexec alexec marked this pull request as draft May 25, 2021 17:14
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title feat(server): Enable pprof. Relates to #6000 fix(server): Only hydrate nodes if they are needed. Fixes #6000 May 26, 2021
@alexec alexec marked this pull request as ready for review May 27, 2021 15:43
@alexec alexec requested a review from jessesuen as a code owner May 27, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argo-server repeatable crash due to out of memory on big workflows
2 participants