fix(server): Only hydrate nodes if they are needed. Fixes #6000 (#6004)

api/openapi-spec/swagger.json

@@ -2204,6 +2204,11 @@
  "description": "The continue option should be set when retrieving more results from the server. Since this value is\nserver defined, clients may only use the continue value from a previous query result with identical\nquery parameters (except for the value of continue) and the server may reject a continue value it\ndoes not recognize. If the specified continue value is no longer valid whether due to expiration\n(generally five to fifteen minutes) or a configuration change on the server, the server will\nrespond with a 410 ResourceExpired error together with a continue token. If the client needs a\nconsistent list, it must restart their list without the continue field. Otherwise, the client may\nsend another list request with the token received with the 410 error, the server will respond with\na list starting from the next key, but from the latest snapshot, which is inconsistent from the\nprevious list results - objects that are created, modified, or deleted after the first list request\nwill be included in the response, as long as their keys are after the \"next key\".\n\nThis field is not supported when watch is true. Clients may start a watch from the last\nresourceVersion value returned by the server and not miss any modifications.",
  "name": "listOptions.continue",
  "in": "query"
+ },
+ {
+ "type": "string",
+ "name": "fields",
+ "in": "query"
  }
  ],
  "responses": {

cmd/argo/commands/server.go

@@ -3,8 +3,11 @@ package commands
 import (
  "crypto/tls"
  "fmt"
+ "net/http"
+ _ "net/http/pprof"
  "os"
  "reflect"
+ "strconv"
  "time"
 
  eventsource "github.com/argoproj/argo-events/pkg/client/eventsource/clientset/versioned"
@@ -153,6 +156,18 @@ See %s`, help.ArgoSever),
  return err
  }
 
+ // disabled by default, for security
+ if x, enabled := os.LookupEnv("ARGO_SERVER_PPROF"); enabled {
+ port, err := strconv.Atoi(x)
+ if err != nil {
+ return err
+ }
+ go func() {
+ log.Infof("starting server for pprof on :%d, see https://golang.org/pkg/net/http/pprof/", port)
+ log.Println(http.ListenAndServe(fmt.Sprintf(":%d", port), nil))
+ }()
+ }
+
  server.Run(ctx, port, browserOpenFunc)
  return nil
  },

pkg/apiclient/workflow/workflow.proto

@@ -98,6 +98,7 @@ message WorkflowDeleteResponse {
 message WatchWorkflowsRequest {
  string namespace = 1;
  k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 2;
+ string fields = 3;
 }
 
 message WorkflowWatchEvent {