Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Node set updating global output parameter updates global. #5699 #5700

Merged

Conversation

markterm
Copy link
Contributor

Checklist:

@markterm markterm force-pushed the resume-global-output-parameter branch from 31ee0d7 to ad0ded1 Compare April 18, 2021 10:04
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #5700 (666e572) into master (4b3a30f) will increase coverage by 0.27%.
The diff coverage is 90.38%.

❗ Current head 666e572 differs from pull request most recent head 60c2aa7. Consider uploading reports for the commit 60c2aa7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5700      +/-   ##
==========================================
+ Coverage   46.79%   47.07%   +0.27%     
==========================================
  Files         245      246       +1     
  Lines       15398    15485      +87     
==========================================
+ Hits         7206     7289      +83     
- Misses       7280     7284       +4     
  Partials      912      912              
Impacted Files Coverage Δ
workflow/util/util.go 43.92% <58.33%> (+0.64%) ⬆️
.../workflow/v1alpha1/container_set_template_types.go 100.00% <100.00%> (ø)
pkg/apis/workflow/v1alpha1/validation_utils.go 100.00% <100.00%> (ø)
workflow/controller/operator.go 71.14% <100.00%> (-0.24%) ⬇️
workflow/validate/validate.go 73.38% <100.00%> (+0.25%) ⬆️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️
workflow/metrics/server.go 16.66% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3a30f...60c2aa7. Read the comment docs.

@sarabala1979 sarabala1979 self-assigned this Apr 19, 2021
@markterm
Copy link
Contributor Author

markterm commented May 1, 2021

@sarabala1979 please let me know if you have any feedback on this PR.

@sarabala1979
Copy link
Member

@markterm Please fix the failures

@markterm markterm force-pushed the resume-global-output-parameter branch 2 times, most recently from d9e1f94 to 5f33c62 Compare May 3, 2021 19:44
@markterm markterm force-pushed the resume-global-output-parameter branch from 5f33c62 to 60c2aa7 Compare May 3, 2021 20:04
@sarabala1979 sarabala1979 merged commit 8f2acee into argoproj:master May 3, 2021
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
@sarabala1979 sarabala1979 mentioned this pull request May 13, 2021
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants