test

Signed-off-by: Simon Behar <[email protected]>

test/e2e/functional_test.go

@@ -912,6 +912,38 @@ spec:
  DeleteMemoryQuota()
 }
 
+func (s *FunctionalSuite) TestExitCodePNSSleep() {
+ s.Given().
+ Workflow(`apiVersion: argoproj.io/v1alpha1
+kind: Workflow
+metadata:
+ name: cond
+ labels:
+ argo-e2e: true
+spec:
+ entrypoint: conditional-example
+ templates:
+ - name: conditional-example
+ steps:
+ - - name: print-hello
+ template: whalesay
+ - name: whalesay
+ container:
+ image: argoproj/argosay:v2
+ args: [sleep, 5s]
+`).
+ When().
+ SubmitWorkflow().
+ Wait(10 * time.Second).
+ Then().
+ ExpectWorkflow(func(t *testing.T, metadata *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
+ node := status.Nodes.FindByDisplayName("print-hello")
+ if assert.NotNil(t, node) && assert.NotNil(t, node.Outputs) && assert.NotNil(t, node.Outputs.ExitCode) {
+ assert.Equal(t, "0", *node.Outputs.ExitCode)
+ }
+ })
+}
+
 func TestFunctionalSuite(t *testing.T) {
  suite.Run(t, new(FunctionalSuite))
 }

workflow/executor/pns/pns.go

@@ -372,7 +372,7 @@ func (p *PNSExecutor) updateCtrIDMap() {
 func (p *PNSExecutor) GetTerminatedContainerStatus(containerID string) (*corev1.Pod, *corev1.ContainerStatus, error) {
  var pod *corev1.Pod
  var containerStatus *corev1.ContainerStatus
- err := wait.Poll(500*time.Millisecond, 2*time.Second, func() (bool, error) {
+ err := wait.Poll(1*time.Second, 3*time.Second, func() (bool, error) {
  podRes, err := p.clientset.CoreV1().Pods(p.namespace).Get(p.podName, metav1.GetOptions{})
  if err != nil {
  return false, fmt.Errorf("could not get pod: %s", err)