fix: Ensure ContainerStatus in PNS is terminated before continuing #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <[email protected]>
alexec
reviewed
Nov 5, 2020
Signed-off-by: Simon Behar <[email protected]>
alexec
reviewed
Nov 9, 2020
| func (p *PNSExecutor) GetTerminatedContainerStatus(containerID string) (*corev1.Pod, *corev1.ContainerStatus, error) { | ||
| var pod *corev1.Pod | ||
| var containerStatus *corev1.ContainerStatus | ||
| err := wait.Poll(1*time.Second, 3*time.Second, func() (bool, error) { |
There was a problem hiding this comment.
is this try 3 times over 3 seconds?
There was a problem hiding this comment.
Correct. According to my manual testing, this should succeed on the first try around 95% of the time. It should almost always succeed by the second try.
alexec
approved these changes
Nov 10, 2020
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
…rgoproj#4469) Signed-off-by: Simon Behar <[email protected]> Signed-off-by: Alex Capras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4406
Signed-off-by: Simon Behar [email protected]
Checklist: