Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CLI): Add -v and --verbose to Argo CLI #2814

Merged
merged 3 commits into from
Apr 27, 2020
Merged

feat(CLI): Add -v and --verbose to Argo CLI #2814

merged 3 commits into from
Apr 27, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 23, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

To help get more diagnostics for errors.

@alexec alexec marked this pull request as ready for review April 24, 2020 00:32
@alexec alexec requested a review from simster7 April 24, 2020 00:32
@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@alexec alexec added this to the v2.9 milestone Apr 24, 2020
simster7
simster7 approved these changes Apr 27, 2020
View reviewed changes
cmd/argo/commands/root.go
Comment on lines +69 to +71
if verbose {
logLevel = "debug"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make the field a string field? What if we want to add more fine-tuned logging in the future?

@alexec alexec changed the title chore: Add -v and --verbose to Argo CLI feat(CLI): Add -v and --verbose to Argo CLI Apr 27, 2020
@alexec alexec merged commit 31358d6 into argoproj:master Apr 27, 2020
@alexec alexec deleted the chore-verbose branch April 27, 2020 17:24
@alexec alexec mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexec @simster7