-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back flag for kubernetes log level in CLI #4093
Labels
Milestone
Comments
alexec
added
the
type/regression
Regression from previous behavior (a specific type of bug)
label
Sep 22, 2020
Can I suggest we enable this with |
Caused by #2814? |
// global log level
var logLevel string
var glogLevel int
var verbose bool
command.PersistentPreRun = func(cmd *cobra.Command, args []string) {
if verbose {
logLevel = "debug"
glogLevel = 9
}
cli.SetLogLevel(logLevel)
cli.SetGLogLevel(glogLevel)
log.WithField("version", argo.GetVersion()).Debug("CLI version")
}
command.PersistentFlags().StringVar(&logLevel, "loglevel", "info", "Set the logging level. One of: debug|info|warn|error")
command.PersistentFlags().IntVar(&glogLevel, "gloglevel", 0, "Set the logging level. One of: debug|info|warn|error")
command.PersistentFlags().BoolVarP(&verbose, "verbose", "v", false, "Enabled verbose logging, i.e. --loglevel debug") |
Because there was not tests? ;) |
alexec
added a commit
to alexec/argo-workflows
that referenced
this issue
Sep 22, 2020
6 tasks
alexec
added a commit
that referenced
this issue
Sep 23, 2020
alexec
added a commit
that referenced
this issue
Sep 23, 2020
Will come in v2.11.1 |
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this issue
Nov 12, 2020
) Signed-off-by: Alex Capras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
We used to have a
--gloglevel
in argo cli which would translate to glog (now klog) levels. This was useful for debugging kubernetes payloads. It got removed somehow so we should add it back.Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: