Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Revert to Node 16 LTS #10615

Merged
merged 2 commits into from
Mar 4, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: Revert to Node 16 LTS
Signed-off-by: Alex Collins <[email protected]>
  • Loading branch information
alexec committed Feb 28, 2023
commit 9f0e0d3ff2f79440405550f94b4ad69c9b259f7d
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "19"
node-version: "16"
cache: yarn
cache-dependency-path: ui/yarn.lock
- run: yarn --cwd ui install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
if [ $tag = "master" ]; then
tag="latest"
fi

tag_suffix=$(echo $PLATFORM | sed -r "s/\//-/g")
image_name="${DOCKERIO_ORG}/${TARGET}:${tag}-${tag_suffix}"

Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
if [ $tag = "master" ]; then
tag="latest"
fi

tag_suffix=$(echo $PLATFORM | sed -r "s/\//-/g")
image_name="${DOCKERIO_ORG}/${TARGET}:${tag}-${tag_suffix}"

Expand Down Expand Up @@ -348,7 +348,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "19"
node-version: "16"
- uses: actions/setup-go@v3
with:
go-version: "1.19"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ COPY . .

####################################################################################################

FROM node:19-alpine as argo-ui
FROM node:16-alpine as argo-ui

RUN apk update && apk add --no-cache git

Expand Down
4 changes: 2 additions & 2 deletions docs/running-locally.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ Note:

## Requirements

* [Go 1.18](https://golang.org/dl/)
* [Go](https://golang.org/dl/)
* [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable)
* [Docker](https://docs.docker.com/get-docker/)
* [`protoc`](http:https://google.github.io/proto-lens/installing-protoc.html)
* [`node` >= 16.15.0](https://nodejs.org/download/release/latest-v16.x/) for running the UI
* [`node`](https://nodejs.org/download/release/latest-v16.x/) for running the UI
* A local Kubernetes cluster ([`k3d`](https://k3d.io/), [`kind`](https://kind.sigs.k8s.io/docs/user/quick-start/#installation), or [`minikube`](https://minikube.sigs.k8s.io/docs/start/))

We recommend using [K3D](https://k3d.io/) to set up the local Kubernetes cluster since this will allow you to test RBAC
Expand Down
6 changes: 3 additions & 3 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"src"
],
"scripts": {
"build": "rm -Rf dist && NODE_OPTIONS='--openssl-legacy-provider' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
"start": "NODE_OPTIONS='--no-experimental-fetch --openssl-legacy-provider' webpack-dev-server --config ./src/app/webpack.config.js",
"build": "rm -Rf dist && NODE_OPTIONS='' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
"start": "NODE_OPTIONS='--no-experimental-fetch' webpack-dev-server --config ./src/app/webpack.config.js",
"lint": "tslint --fix -p ./src/app",
"test": "jest"
},
"engines": {
"node": ">=19"
"node": ">=16"
},
"dependencies": {
"argo-ui": "https://github.com/argoproj/argo-ui.git#v2.5.0",
Expand Down