Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Revert to Node 16 LTS #10615

Merged
merged 2 commits into from
Mar 4, 2023
Merged

build: Revert to Node 16 LTS #10615

merged 2 commits into from
Mar 4, 2023

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 28, 2023 •
edited
Loading

Node 19 is not LTS. Node 18 is, but does not work with the SSO problem.

This fixes that.

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

alexec and others added 2 commits February 28, 2023 13:31
@alexec
build: Revert to Node 16 LTS
9f0e0d3 
Signed-off-by: Alex Collins <[email protected]>
@alexec
Update ci-build.yaml
3cbd7c0 
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review February 28, 2023 22:39
@alexec alexec enabled auto-merge (squash) February 28, 2023 22:39
@yokishava yokishava mentioned this pull request Mar 1, 2023
Closed
@alexec alexec mentioned this pull request Mar 3, 2023
Merged
8 tasks
@alexec alexec merged commit 07b3811 into master Mar 4, 2023
@alexec alexec deleted the node-16 branch March 4, 2023 00:48
alexec added a commit that referenced this pull request Mar 5, 2023
@alexec
build: Revert to Node 16 LTS (#10615)
32e541a 
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@jmeridth jmeridth mentioned this pull request Mar 6, 2023
Merged
20 tasks
@terrytangyuan terrytangyuan mentioned this pull request Mar 24, 2023
Closed
33 tasks
terrytangyuan pushed a commit that referenced this pull request Mar 29, 2023
@alexec @terrytangyuan
build: Revert to Node 16 LTS (#10615)
7e0dc0a 
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
@alexec @JPZ13
build: Revert to Node 16 LTS (argoproj#10615)
5686959 
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexec @terrytangyuan @agilgur5