Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Storage account as default artifact repo #9595

Closed
Transmitt0r opened this issue Sep 15, 2022 · 4 comments · Fixed by #9597
Closed

Support Azure Storage account as default artifact repo #9595

Transmitt0r opened this issue Sep 15, 2022 · 4 comments · Fixed by #9597

Comments

@Transmitt0r
Copy link
Contributor

This is a new issue based on my comment in #1540

Azure File storage support is now available for artifacts, but it can not be used as defaultArtifactRepo yep.
Now that minio gateway is being deprecated, this seems like an important thing to add to support deployments on Azure.

Does this support having azure blob storage as the default artifact repo? I can't seem to get it working

Same, when I try to use azure as defaultArtifactRepo, the configmap is empty except this exception:

apiVersion: v1
data:
  config: "containerRuntimeExecutor: emissary\nartifactRepository:\n  s3:\n    accessKeySecret:\n
    \     key: accesskey\n      name: \n    secretKeySecret:\n      key: secretkey\n
    \     name: \n    bucket: \n    endpoint: \n    insecure: false\n"
kind: ConfigMap
...

Originally posted by @Transmitt0r in #1540 (comment)

@terrytangyuan
Copy link
Member

You need to use the latest version, at least 3.4.

@Transmitt0r
Copy link
Contributor Author

Ah, then the doc's have not been updated yet as of v3.4.0-rc4. Do you maybe also know in which PR/commit this was introduced?

@terrytangyuan
Copy link
Member

It's added in #9026 by @brianloss. @brianloss Would you like to help update the documentation?

@brianloss
Copy link
Contributor

It's already documented on that page in the table at the top and with a detailed section
I can also add a comment or another section under the Configure the Default Artifact Repository header since it seems to be confusing to not have it there.

terrytangyuan pushed a commit that referenced this issue Sep 15, 2022
… Azure Blob Storage. Fixes #9595 (#9597)

docs: update default artifact repository docs for Azure

Signed-off-by: Brian Loss <[email protected]>

Signed-off-by: Brian Loss <[email protected]>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
… Azure Blob Storage. Fixes argoproj#9595 (argoproj#9597)

docs: update default artifact repository docs for Azure

Signed-off-by: Brian Loss <[email protected]>

Signed-off-by: Brian Loss <[email protected]>
Signed-off-by: juchao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants