Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not applying in resource for azure blob storage in output artifacts section #1444

Closed
richoku opened this issue Sep 9, 2022 · 3 comments · Fixed by #1488
Closed

Comments

@richoku
Copy link

richoku commented Sep 9, 2022

Describe the bug

We want to use azure blob storage to store artifacts there from our argo-workflows.

Issue:
kubectl apply -f my-resource-file.yaml --namespace=mynamespace does not apply the changes to use azure blob storage. There is no error message. The output artifacts section does not contain the configured settings.

Previous version of my-resource-file.yaml (outputs section):

      outputs:
        artifacts:
          - name: ids
            path: /tmp/image-ids.json

New version of my-resource-file.yaml (outputs section):

      outputs:
        artifacts:
          - name: ids
            path: /tmp/image-ids.json
            azure:
              endpoint: https://myblobstorage.blob.core.windows.net/
              container: my-artifact-repository
              blob: /tmp/image-ids.json
              accountKeySecret:
                name: my-storage-account-name
                key: my-storage-account-key

Summary

It seems that only s3 object store and gcs object store are supported since azure is not available within artifactRepository in values.yaml of the helm chart. Please enable/support this feature.

Thanks in advance
Richard

Related helm chart

argo-workflows

Helm chart version

0.17.1

To Reproduce

As described above:
Extend your resource-file.yaml with:

      outputs:
        artifacts:
          - name: ids
            path: /tmp/image-ids.json
            azure:
              endpoint: https://myblobstorage.blob.core.windows.net/
              container: my-artifact-repository
              blob: /tmp/image-ids.json
              accountKeySecret:
                name: my-storage-account-name
                key: my-storage-account-key

and apply with: kubectl apply -f my-resource-file.yaml --namespace=mynamespace.

Expected behavior

Workflows can use azure blob storage to store artifacts.

Screenshots

No response

Additional context

Used setup:

@richoku
Copy link
Author

richoku commented Sep 15, 2022

Hi,
any chance to get feedback for this bug?

Best regards,
Richard

@Transmitt0r
Copy link

This is especially useful with argo-workflows 3.4 since it now support azure storage accounts as default artifact repositories (argoproj/argo-workflows#9595)

@yu-croco
Copy link
Collaborator

Hi, thank you for reporting!
I made a PR for supporting Azure Blob Storage. Please wait for a while to be merged. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants