test: updated gitSync commands file

[NandanAnantharamu]

RCA: There are many unused commands within gitSync.js file

Solution:
Checked the gitSync in both CE and EE repository and we are removing those commands which are not used in any tests as part of cleanup activity
Equivalent EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4280

/ok-to-test tags="@tag.All"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9266669234
Commit: def6377
Cypress dashboard url: Click here!

[coderabbitai]

Walkthrough

Walkthrough

The revokeAccessGit function, which handled disconnecting the app from a Git repository, was removed from gitSync.js. This function included interactions with UI elements and assertions to verify the disconnection state. The removal simplifies the file by eliminating the logic related to revoking Git access.

Changes

File	Change Summary
app/client/cypress/support/gitSync.js	Removed the revokeAccessGit function, which handled revoking Git repository access.

Sequence Diagram(s) (Beta)

The changes are too simple and specific to generate a meaningful sequence diagram.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec67a0a and def6377.

Files selected for processing (1)

• app/client/cypress/support/gitSync.js (1 hunks)

Additional Context Used

Biome (3)

app/client/cypress/support/gitSync.js (3)

35-35: Template literals are preferred over string concatenation.

---

101-101: Do not use template literals if interpolation and special-character handling are not needed.

---

103-103: Do not use template literals if interpolation and special-character handling are not needed.

Additional comments not posted (7)

app/client/cypress/support/gitSync.js (7)

Line range hint 22-39: This command is well-structured and follows good practices for interacting with UI elements.

---

Line range hint 41-60: This command effectively handles branch switching with appropriate error handling and dynamic waits.

---

Line range hint 62-86: This command is well-structured and follows good practices for handling commit and push operations with appropriate network call assertions.

---

Line range hint 88-117: This command is well-structured and follows good practices for handling merge operations with appropriate network call interceptions and assertions.

---

Line range hint 119-158: This command is well-structured and follows good practices for handling app imports from Git with appropriate network call interceptions and assertions.

---

Line range hint 160-182: This command is well-structured and follows good practices for discarding Git changes with appropriate UI interactions and assertions.

---

Line range hint 184-224: This command is well-structured and follows good practices for regenerating SSH keys with appropriate protocol handling and network call interceptions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

app/client/cypress/support/gitSync.js (2)

Line range hint 35-35: Consider using template literals for better readability and consistency.

- agHelper.ClearNType(gitSyncLocators.branchSearchInput, `${branch}`);
+ agHelper.ClearNType(gitSyncLocators.branchSearchInput, branch);

---

Line range hint 9-20: Reduce the use of cy.wait to improve test performance and reliability.

Consider replacing fixed waits with more dynamic waiting mechanisms, such as waiting for specific elements or API calls to complete.