Skip to content

Commit

Permalink
test: updated gitSync commands file (#33633)
Browse files Browse the repository at this point in the history
RCA: There are many unused commands within gitSync.js file

Solution:
Checked the gitSync in both CE and EE repository and we are removing
those commands which are not used in any tests as part of cleanup
activity
Equivalent EE PR: appsmithorg/appsmith-ee#4280


/ok-to-test tags="@tag.All"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9266669234>
> Commit: def6377
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9266669234&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
  • Loading branch information
NandanAnantharamu committed May 28, 2024
1 parent ba23317 commit 4ebc523
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions app/client/cypress/support/gitSync.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,6 @@ const assertHelper = ObjectsRegistry.AssertHelper;

const commonLocators = require("../locators/commonlocators.json");

Cypress.Commands.add("revokeAccessGit", (appName) => {
cy.xpath("//span[text()= `${appName}`]").parent().next().click();
cy.get(gitSyncLocators.disconnectAppNameInput).type(appName);
cy.get(gitSyncLocators.disconnectButton).click();
cy.intercept("POST", "api/v1/git/disconnect/app/*").as("disconnect");
cy.get(gitSyncLocators.disconnectButton).click();
cy.wait("@disconnect").should(
"have.nested.property",
"response.body.responseMeta.status",
200,
);
cy.window()
.its("store")
.invoke("getState")
.then((state) => {
const { id, name } = state.ui.gitSync.disconnectingGitApp;
expect(name).to.eq("");
expect(id).to.eq("");
});
});

Cypress.Commands.add("latestDeployPreview", () => {
cy.intercept("POST", "/api/v1/applications/publish/*").as("publishApp");
// Wait before publish
Expand Down

0 comments on commit 4ebc523

Please sign in to comment.