Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: safe crash application on theme APIs failure #13743

Merged
merged 2 commits into from
May 11, 2022
Merged

chore: safe crash application on theme APIs failure #13743

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b461e1
Safe crash application on theme APIs failure
May 11, 2022
5fbffca
Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…
May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Safe crash application on theme APIs failure
  • Loading branch information
arunvjn committed May 11, 2022
commit 8b461e10dc80a6cb0ce11e2b3dc6b95b0afcd9a5
4 changes: 4 additions & 0 deletions app/client/src/sagas/InitSagas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ function* initiateEditorActions(applicationId: string) {
const failureActionEffects = [
ReduxActionErrorTypes.FETCH_JS_ACTIONS_ERROR,
ReduxActionErrorTypes.FETCH_ACTIONS_ERROR,
ReduxActionErrorTypes.FETCH_APP_THEMES_ERROR,
ReduxActionErrorTypes.FETCH_SELECTED_APP_THEME_ERROR,
];
const allActionCalls: boolean = yield failFastApiCalls(
initActionsCalls,
Expand Down Expand Up @@ -441,6 +443,8 @@ export function* initializeAppViewerSaga(
[
ReduxActionErrorTypes.FETCH_ACTIONS_VIEW_MODE_ERROR,
ReduxActionErrorTypes.FETCH_JS_ACTIONS_VIEW_MODE_ERROR,
ReduxActionErrorTypes.FETCH_APP_THEMES_ERROR,
ReduxActionErrorTypes.FETCH_SELECTED_APP_THEME_ERROR,
],
);

Expand Down