Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: safe crash application on theme APIs failure #13743

Merged
merged 2 commits into from
May 11, 2022
Merged

chore: safe crash application on theme APIs failure #13743

merged 2 commits into from
May 11, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 11, 2022 •
edited by github-actions bot
Loading

Description

Added theme error effects into failureActionEffect during app initialisation.

Type of change

  • Minor refactor

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@vercel
Copy link

vercel bot commented May 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 11, 2022 at 7:28AM (UTC)

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 11, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

3 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 11, 2022

/ok-to-test sha=8b461e1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2305340718.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8b461e1.
PR: 13743.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 11, 2022

/ok-to-test sha=5fbffca

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305340718.
Commit: 8b461e1.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 901.98 860.58 789.72 2290.68 956.32 901.98 1159.86 54.75 48.97
painting 9.06 9.55 13.69 7.98 6.38 9.06 9.33 29.15 26.15
rendering 346.58 353.44 306.55 427.52 362.02 353.44 359.22 12.17 10.88
BIND_TABLE_DATA
scripting 2496.69 2315.38 2203.89 2291.14 2241.89 2291.14 2309.8 4.90 4.38
painting 23.77 25.59 31.58 23.04 19.6 23.77 24.72 17.84 15.94
rendering 754.75 693.57 817.4 714.08 711.36 714.08 738.23 6.72 6.01
CLICK_ON_TABLE_ROW
scripting 2574.48 2245.66 2346.31 2794.15 2059.76 2346.31 2404.07 11.91 10.66
painting 33.74 20.41 24.74 21.06 28.84 24.74 25.76 21.70 19.41
rendering 318.26 332.99 340.18 348.57 297.42 332.99 327.48 6.16 5.51
UPDATE_POST_TITLE
scripting 3617.52 3930.78 4756.06 4556.59 3483.17 3930.78 4068.82 13.88 12.42
painting 15.98 27.74 25.7 21.98 34.21 25.7 25.12 26.95 24.08
rendering 420.87 463.71 488.66 430.64 423.26 430.64 445.43 6.66 5.95
OPEN_MODAL
scripting 1612.58 1515.34 1626.68 1605.88 1526.63 1605.88 1577.42 3.31 2.96
painting 18.96 15 17.66 15.94 25.67 17.66 18.65 22.57 20.21
rendering 510.22 488.47 549.55 540.89 514.67 514.67 520.76 4.73 4.23
CLOSE_MODAL
scripting 748.85 826.1 847.25 923.99 817.19 826.1 832.68 7.56 6.76
painting 5.83 6.44 8.36 5.93 15.48 6.44 8.41 48.51 43.40
rendering 371.74 408.64 421.13 422.96 384.92 408.64 401.88 5.64 5.05
SELECT_WIDGET_MENU_OPEN
scripting 1604 1797.84 1668.54 1814.36 1578.98 1668.54 1692.74 6.42 5.74
painting 6.71 11.71 11.1 11.31 7.46 11.1 9.66 24.53 21.95
rendering 567.66 624.21 640.41 729.28 621.1 624.21 636.53 9.21 8.24
SELECT_WIDGET_SELECT_OPTION
scripting 268.04 272.92 353.45 334.35 302.68 302.68 306.29 12.22 10.93
painting 3.58 3.65 11.92 6.13 4.23 4.23 5.9 59.66 53.39
rendering 19.02 18.53 30.58 31.04 23.86 23.86 24.61 24.54 21.94

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2305600245.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5fbffca.
PR: 13743.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305600245.
Commit: 5fbffca.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 716.63 692.49 751.12 823.19 799.75 751.12 756.64 7.25 6.48
painting 7.73 4.95 3.52 3.89 3.84 3.89 4.79 36.12 32.36
rendering 283.73 279.03 277.67 294.18 326.44 283.73 292.21 6.91 6.18
BIND_TABLE_DATA
scripting 2164.48 2207.36 2237.32 2246.4 2270.14 2237.32 2225.14 1.83 1.64
painting 18.08 14.73 9.19 17 22.07 17 16.21 29.24 26.16
rendering 594.08 581.02 628.5 585.44 597.52 594.08 597.31 3.12 2.79
CLICK_ON_TABLE_ROW
scripting 1871.61 1773.79 1925.46 2079.49 2046.08 1925.46 1939.29 6.48 5.80
painting 13.46 20.83 15.72 16.93 22.79 16.93 17.95 21.17 18.94
rendering 275.08 269.9 275.38 291.32 295.11 275.38 281.36 3.95 3.54
UPDATE_POST_TITLE
scripting 2817.92 2892.21 2914.3 3103.57 3349.37 2914.3 3015.47 7.11 6.36
painting 33.61 15.72 12.3 17.13 27.02 17.13 21.16 41.87 37.43
rendering 364.79 348.49 349.31 402.12 391.76 364.79 371.29 6.62 5.92
OPEN_MODAL
scripting 1121.45 1252.64 1562.8 1448.13 1249.74 1252.64 1326.95 13.27 11.87
painting 8.3 10.28 14.98 12.51 9.76 10.28 11.17 23.37 20.95
rendering 408.08 409.04 479.39 429.88 436.59 429.88 432.6 6.71 6.00
CLOSE_MODAL
scripting 691.35 707.68 692.42 770.32 717.21 707.68 715.8 4.52 4.04
painting 5.49 4.29 12.61 4.62 4.75 4.75 6.35 55.59 49.61
rendering 349.37 326.84 388.05 341.12 373.68 349.37 355.81 6.96 6.23
SELECT_WIDGET_MENU_OPEN
scripting 1577.89 1557.6 1501.49 1481.82 1578.83 1557.6 1539.53 2.93 2.62
painting 10.43 9.33 5.96 5.95 9.87 9.33 8.31 26.23 23.47
rendering 532.73 507.54 504.4 506.12 544.03 507.54 518.96 3.51 3.14
SELECT_WIDGET_SELECT_OPTION
scripting 221.13 212.18 288.72 291.96 266.57 266.57 256.11 14.62 13.08
painting 3.51 4.33 7.71 2.93 2.74 3.51 4.24 47.88 42.92
rendering 15.81 15.48 19.71 19.57 15.23 15.81 17.16 13.23 11.83

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305600245.
Commit: 5fbffca.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 716.63 692.49 751.12 823.19 799.75 751.12 756.64 7.25 6.48
painting 7.73 4.95 3.52 3.89 3.84 3.89 4.79 36.12 32.36
rendering 283.73 279.03 277.67 294.18 326.44 283.73 292.21 6.91 6.18
BIND_TABLE_DATA
scripting 2164.48 2207.36 2237.32 2246.4 2270.14 2237.32 2225.14 1.83 1.64
painting 18.08 14.73 9.19 17 22.07 17 16.21 29.24 26.16
rendering 594.08 581.02 628.5 585.44 597.52 594.08 597.31 3.12 2.79
CLICK_ON_TABLE_ROW
scripting 1871.61 1773.79 1925.46 2079.49 2046.08 1925.46 1939.29 6.48 5.80
painting 13.46 20.83 15.72 16.93 22.79 16.93 17.95 21.17 18.94
rendering 275.08 269.9 275.38 291.32 295.11 275.38 281.36 3.95 3.54
UPDATE_POST_TITLE
scripting 2817.92 2892.21 2914.3 3103.57 3349.37 2914.3 3015.47 7.11 6.36
painting 33.61 15.72 12.3 17.13 27.02 17.13 21.16 41.87 37.43
rendering 364.79 348.49 349.31 402.12 391.76 364.79 371.29 6.62 5.92
OPEN_MODAL
scripting 1121.45 1252.64 1562.8 1448.13 1249.74 1252.64 1326.95 13.27 11.87
painting 8.3 10.28 14.98 12.51 9.76 10.28 11.17 23.37 20.95
rendering 408.08 409.04 479.39 429.88 436.59 429.88 432.6 6.71 6.00
CLOSE_MODAL
scripting 691.35 707.68 692.42 770.32 717.21 707.68 715.8 4.52 4.04
painting 5.49 4.29 12.61 4.62 4.75 4.75 6.35 55.59 49.61
rendering 349.37 326.84 388.05 341.12 373.68 349.37 355.81 6.96 6.23
SELECT_WIDGET_MENU_OPEN
scripting 1577.89 1557.6 1501.49 1481.82 1578.83 1557.6 1539.53 2.93 2.62
painting 10.43 9.33 5.96 5.95 9.87 9.33 8.31 26.23 23.47
rendering 532.73 507.54 504.4 506.12 544.03 507.54 518.96 3.51 3.14
SELECT_WIDGET_SELECT_OPTION
scripting 221.13 212.18 288.72 291.96 266.57 266.57 256.11 14.62 13.08
painting 3.51 4.33 7.71 2.93 2.74 3.51 4.24 47.88 42.92
rendering 15.81 15.48 19.71 19.57 15.23 15.81 17.16 13.23 11.83

@arunvjn arunvjn merged commit 8084744 into release May 11, 2022
@arunvjn arunvjn deleted the chore/fail-fast-on-theme-apis branch May 11, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees

@jsartisan jsartisan

Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arunvjn @jsartisan