-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: numeric type input widget should accept zero after decimal point #11923
Conversation
…#11579) - Derived properties of List widget children won't work. so having the text property of Input wiget as a derived property causes issue. hence changing it to a meta property.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/FKxnyB1irQc1UoX7Su9PMw6QWHqS |
/ok-to-test sha=9b534d1 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1996204796. |
/ok-to-test sha=4be3ce4 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1996507675. |
@sbalaji1192 Tested and LGTM |
/ok-to-test sha=4be3ce4 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1998348612. |
/ok-to-test sha=4be3ce4 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1999728037. |
/ok-to-test sha=20c699b |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1999837660. |
/ok-to-test sha=ad3a3ea |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2002523033. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2002523033. Click to view performance test results
|
…appsmithorg#11923) - Derived properties of List widget children won't work. so having the text property of the Input widget as a derived property causes issues. hence having it as a meta property.
Description
Originally we solved this issue by converting the text property into a derived property. but that started causing issues when the Input widget was placed inside the List widget. #11833
Note:
But derived properties of List widget children won't work. so having the text
property of the Input widget as a derived property causes issues. hence changing
it to a meta property.
Fixes #11449
Fixes #11839
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased