-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: null as defaultValue evaluates to 0 in Input widget number type #11839
Comments
CC @ashit-rath |
|
@btsgh |
@sbalaji1192 is this a migration? |
Me and @ashit-rath were discussing this that we should support null overall in all the widgets. We will need to do on a bigger level. If this is not a migration, we are good to go with this fix. |
@dilippitchika Could you explain what do you mean by migration? |
If the user is already using {{null}} in their number input widget and it was going to 0, what will happen to those number inputs now? |
@dilippitchika We won't convert the value to 0 and show an error border around the defaultValue. |
@sbalaji1192 won't this break flows which are using {{null}}? |
@dilippitchika It won't break the application. Just that input value will be empty. Is it not a edge case? |
Not sure, because the data has changed for those cases. Is this in production now? |
@dilippitchika yeah. This is in production now. |
Discussed with @sbalaji1192, the conlusion is - No changes to this PR, it will stay the same. We haven't heard from users yet, so we think this change is fine for now. In future, we are planning to support null values across all fields |
As per comments above and my observation on Release, marking this issue as fixed. |
Is there an existing issue for this?
Description
When {{null}} is bound to defaultValue of Input widget Number type, it evaluates to 0.
Steps To Reproduce
Public Sample App
No response
Version
clound
The text was updated successfully, but these errors were encountered: