Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning error in pdftops filter with landscape pages #243

Closed
michaelrsweet opened this issue Aug 24, 2003 · 2 comments
Closed

Positioning error in pdftops filter with landscape pages #243

michaelrsweet opened this issue Aug 24, 2003 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

Version: 1.1.19
CUPS.org User: h.blischke

Landscape pages are positioned too far to the left (by the
amount of left plus right margin). The x-shift after the rotation has to be done by the paper width instead of the width of the imageable area. See the following diff:
---snip---
*** PSOutputDev.cxx Mi Mai 14 20:22:24 2003
--- new.PSOutputDev.cxx So Aug 24 20:14:25 2003


*** 1719,1725 ****
writePS("pdfStartPage\n");
writePS("90 rotate\n");
tx = -x1;
! ty = -(y1 + imageWidth);
t = width;
width = height;
height = t;
--- 1719,1725 ----
writePS("pdfStartPage\n");
writePS("90 rotate\n");
tx = -x1;
! ty = -(y1 + width);
t = width;
width = height;
height = t;
----snip----

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

Actually, you don't want to use "width", you want "globalParams->getPSPaperWidth()"... "width" is the imageable area which is usually less than the full width of the page.

We'll roll this into the pending updates for the pdftops filter for 1.1.20rc1.

Thanks for the report!

@michaelrsweet
Copy link
Collaborator Author

CUPS.org User: mike

OK, a fix is in CVS now, along with support for unscaled/offset output (new "fitplot" support in the pdftops filter, with the default to not fit...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant