Fix potential deadlock (OpenPrinting #243)

apple · Sep 7, 2021 · fd50212 · fd50212
1 parent 3499fe1
commit fd50212
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cups/tls-darwin.c b/cups/tls-darwin.c
@@ -1,7 +1,8 @@
 /*
  * TLS support code for CUPS on macOS.
  *
- * Copyright © 2007-2019 by Apple Inc.
+ * Copyright © 2021 by OpenPrinting
+ * Copyright © 2007-2021 by Apple Inc.
  * Copyright © 1997-2007 by Easy Software Products, all rights reserved.
  *
  * Licensed under Apache License v2.0. See the file "LICENSE" for more
@@ -291,7 +292,7 @@ cupsMakeServerCredentials(
  else
  tls_selfsigned = ident;
 
- _cupsMutexLock(&tls_mutex);
+ _cupsMutexUnlock(&tls_mutex);
 
 # if 0 /* Someday perhaps SecItemCopyMatching will work for identities, at which point */
  CFTypeRef itemKeys[] = { kSecClass, kSecAttrLabel, kSecValueRef };