Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[NumPy] Add NumPy support for norm #17014

Merged
merged 29 commits into from
Jan 24, 2020
Merged

[NumPy] Add NumPy support for norm #17014

merged 29 commits into from
Jan 24, 2020

Conversation

vexilligera
Copy link
Contributor

@vexilligera vexilligera commented Dec 8, 2019

Description

implements np.linalg.norm

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 self-assigned this Dec 9, 2019
@haojin2 haojin2 added the Numpy label Dec 9, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Dec 9, 2019
@vexilligera vexilligera changed the title [NumPy][WIP] Add NumPy support for norm [NumPy] Add NumPy support for norm Dec 18, 2019
@haojin2 haojin2 merged commit e1435a3 into apache:master Jan 24, 2020
numpy automation moved this from In progress to Done Jan 24, 2020
@haojin2 haojin2 mentioned this pull request Jan 24, 2020
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants