Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] . add op linalg norm #16129

Closed
wants to merge 2 commits into from
Closed

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Sep 9, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gyshi gyshi requested a review from szha as a code owner September 9, 2019 14:53
@haojin2 haojin2 self-assigned this Sep 9, 2019
@haojin2 haojin2 added the Numpy label Sep 9, 2019
@gyshi gyshi force-pushed the add_linalg_norm branch 3 times, most recently from 5f0f533 to 7a6ee8f Compare September 10, 2019 03:05
return _npi.norm(x, ord=2, axis=axis, keepdims=keepdims, flag=0)
elif ord == 2:
return _npi.norm(x, ord=2, axis=axis, keepdims=keepdims, flag=-1)
elif ord == 'nuc':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 161 already eliminates the case for nuclear norm, is this line still necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's necessary, bacaue if i want to add nuclear norm, i will use it, you can think it is repeating。

@haojin2
Copy link
Contributor

haojin2 commented Jan 24, 2020

#17014 merged, closing this PR.

@haojin2 haojin2 closed this Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants