Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] add op bitwise_not #16947

Merged
merged 8 commits into from
Dec 19, 2019
Merged

[numpy] add op bitwise_not #16947

merged 8 commits into from
Dec 19, 2019

Conversation

Yiyan66
Copy link
Contributor

@Yiyan66 Yiyan66 commented Nov 29, 2019

Description

add op bitwise_not, invert

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Yiyan66 Yiyan66 requested a review from szha as a code owner November 29, 2019 06:43
@xidulu
Copy link
Contributor

xidulu commented Nov 29, 2019

Native numpy supports boolean array as the input of bitwise_not

>>> a = np.ones((2,2),dtype='bool')
>>> np.bitwise_not(a)
array([[False, False],
       [False, False]])

I suggest you cover this case in your tests:
https://github.com/apache/incubator-mxnet/pull/16947/files#diff-c46120f3f0763207179e7ff51e2f989eR1132-R1138

@haojin2 haojin2 self-assigned this Nov 30, 2019
@haojin2 haojin2 added the Numpy label Nov 30, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Nov 30, 2019
@haojin2
Copy link
Contributor

haojin2 commented Dec 12, 2019

@Yiyan66 please get rid of the conflicts. Also, you should not make any changes to the openmp 3rdparty module.

@haojin2 haojin2 merged commit 521c477 into apache:master Dec 19, 2019
numpy automation moved this from In progress to Done Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants