Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] numpy compatible invert #15859

Closed
wants to merge 8 commits into from

Conversation

mikemwx
Copy link
Contributor

@mikemwx mikemwx commented Aug 12, 2019

Description

  • add numpy compatible invert
  • add a helper function for checking if input or output is integer

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add invert and its test
  • a helper function to check for checking if input and output is of type integer at src/operator/operator_common.h type_is_int

Comments

@mikemwx mikemwx requested a review from szha as a code owner August 12, 2019 09:55
@haojin2 haojin2 requested review from haojin2 and reminisce and removed request for szha August 12, 2019 18:37
@haojin2 haojin2 self-assigned this Aug 12, 2019
@haojin2 haojin2 added the Numpy label Aug 12, 2019
@haojin2 haojin2 added this to In progress in numpy via automation Aug 12, 2019
@haojin2
Copy link
Contributor

haojin2 commented Aug 12, 2019

Please fix the build failure

@mikemwx mikemwx force-pushed the np_invert_to_master branch 4 times, most recently from 940208f to 798917a Compare August 14, 2019 03:48
@haojin2
Copy link
Contributor

haojin2 commented Dec 10, 2019

invert supported in #16947, closing this PR.

@haojin2 haojin2 closed this Dec 10, 2019
numpy automation moved this from In progress to Done Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants