This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Exclude external dependencies from MXNet JAR. #15361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current MXNet build process adds external dependencies to the JAR, which may conflict with local dependencies on the classpath. In my case commons-io was replaced by MXNet and caused some method-not-found errors.
Please find my proposed change in the PR. It's work in progress and I'm happy to iterate if we agree on the the general direction. I have seen a similar change on the 1.5.x branch, so I assume we can apply a similar change here.
No testing was done locally and I hope Travis will catch obvious problems.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Comments