MXNET-1302 Exclude commons-codec and commons-io from assembled JAR

[jessr92]

Consumers of MXNet are exposed to the commons-codec and commons-io library versions MXNet uses internally. This change excludes those JARs from the JARs created with make scalapkg.

Description

This PR removes commons-codec and commons-io from the assembled JAR and adds both packages as dependencies in deploy.xml

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

• The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
• Changes are complete (i.e. I finished coding on this PR)
• To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

• commons-io and commons-codec remove from assembled JAR
• commons-io and commons-codec added as dependencies to deploy.xml

Comments

My Maven knowledge is sparse so I may have missed something.

For testing:

• The JAR no longer contains org.apache.commons classes
• make scalapkg && make scalaunittests && make scalaintegrationtests passed on my Ubuntu 18.04 machine (JDK 8).

Originally reported in #13929

[lanking520]

@frankfliu Could you please take a look

[lanking520]

Since we have this dependency specified on parent pom file. All submodules should be able to inherit from there.

@gordon1992 could you please make corresponding changes?

[vandanavk]

@gordon1992 could you resolve branch conflicts?

@frankfliu for review

[zachgk]

@mxnet-label-bot update [Maven, Scala, pr-awaiting-response]

[jessr92]

I shall

• resolve the merge conflict
• remove the unnecessary commons dependencies in submodules
  and update this pull request.

Thank you for looking at this

[jessr92]

@mxnet-label-bot update [Scala, Maven, pr-awaiting-review]

[jessr92]

@mxnet-label-bot update [Scala, Maven, pr-awaiting-response]

[jessr92]

@mxnet-label-bot update [Maven, Scala, pr-awaiting-review]

[lanking520]

Please take a look at the website crash, there seemed to be some problem with it

[jessr92]

Please take a look at the website crash, there seemed to be some problem with it

Fixed. All other CR comments addressed.

Thanks for your time.

[lanking520]

Thanks for your contribution!

[piyushghai]

LGTM. Thanks for your contributions :)

[jessr92]

Thanks for the approvals.

I note the failing of windows-gpu, looks like it was aborted. I'm not sure how to retry this check so I have a green tick which I assume is a requirement prior to merging. Any advice welcomed.

Thanks,
Gordon

[lanking520]

@gordon1992 The path forward is to pull --rebase with master since we decided to disable the Windows test for now

[jessr92]

Ah yes, I see the commit disabling the Windows test. My fork is now up to date with that change.

Thanks,
Gordon

[jessr92]

@mxnet-label-bot update [Maven, Scala, pr-awaiting-merge]