This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fixes flaky test_gluon_rnn.py:test_layer_bidirectional #14682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait for @szha ok before merging. These changes could impact on going RNN changes. |
TaoLv
reviewed
Apr 12, 2019
| @@ -23,7 +23,7 @@ | |||
| import unittest | |||
| from mxnet.test_utils import almost_equal, assert_almost_equal | |||
| from common import assert_raises_cudnn_not_satisfied | |||
|
|
|||
| from tests.python.unittest.common import with_seed | |||
There was a problem hiding this comment.
Can we merge this line into L25?
from common import assert_raises_cudnn_not_satisfied, with_seedThere was a problem hiding this comment.
bad oversight on my behalf. Thank you for catching it!
perdasilva
force-pushed
the
fix_flaky_test_layer_bidirectional
branch
from
236c9c5
to
27fede6
Compare
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 15, 2019
perdasilva
added a commit
to perdasilva/incubator-mxnet
that referenced
this pull request
May 7, 2019
5 tasks
szha
pushed a commit
that referenced
this pull request
May 8, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes flaky test_gluon_rnn.py:test_layer_bidirectional. See #13103