This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Disables flaky test test_gluon_rnn.test_layer_bidirectional #14676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
suggested changes
Apr 11, 2019
|
From the issue it doesn't seem to impact master branch. Do you know why? Would it be possible to use retry to overcome this for now? |
haojin2
added
the
pr-awaiting-response
|
Closing in favor or #14682, which fixed the problem |
|
@szha I just saw your messages. I've increased the tolerance in the test as suggested by other committers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables flaky test
test_gluon_rnn.test_layer_bidirectional. See #13103 for more details.